Skip to content

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Nov 25, 2025

Updates _annotate_external_ids() to only assign ids to actual outputs in current order instead of traversing all producers.

This makes the mapping more robust to structured (tuple/namedtuple) outputs and avoids interference from lifted constants or shared producers.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Updates _annotate_external_ids() to only assign ids to actual outputs
in current order instead of traversing all producers.

This makes the mapping more robust to structured (tuple/namedtuple)
outputs and avoids interference from lifted constants or shared
producers.

Change-Id: I9b3209f6837254c0b2d3a6ddaeef762ec77b5937
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15981

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3d72de2 with merge base a47a122 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@Sebastian-Larsson Sebastian-Larsson merged commit c1113d3 into pytorch:main Dec 2, 2025
295 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants